busbey commented on a change in pull request #2215:
URL: https://github.com/apache/hbase/pull/2215#discussion_r470408344
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java
##########
@@ -856,11 +856,23 @@ void unassign(byte[] regionName, boolean force)
* the request was submitted successfully. We need to check logs for the
details of which regions
* were split/merged.
*
- * @return <code>true</code> if region normalizer ran, <code>false</code>
otherwise.
+ * @return {@code true} if region normalizer ran, {@code false} otherwise.
* @throws IOException if a remote or network exception occurs
*/
boolean normalize() throws IOException;
Review comment:
nit: could we add a default method here that calls
`normalize(NormalizeTableFilterParams)` with an empty set of NTFparams? seems
like we could clean up some stuff in the various *Admin implementations and
`RequestConverter`
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
##########
@@ -1281,6 +1281,14 @@
*/
CompletableFuture<Boolean> normalize();
Review comment:
nit: could we add a default method here that calls
`normalize(NormalizeTableFilterParams)` with an empty set of NTFparams? seems
like we could clean up some stuff in the various *Admin implementations and
`RequestConverter`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
