virajjasani commented on a change in pull request #2219:
URL: https://github.com/apache/hbase/pull/2219#discussion_r470969543
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
##########
@@ -199,6 +199,10 @@ public void close() {
if (!closed.compareAndSet(false, true)) {
return;
}
+ LOG.info("Connection has been closed by {}.",
Thread.currentThread().getName());
Review comment:
I didn't mean to correlate with no of occurrences of this log, I meant
to say user who is interested to know which thread closed the connection would
also likely want to check out `call stacktrace`. So if call stack is at `debug`
level, let's also keep thread name at `debug` level.
But yeah, not everyone enables `debug` log for production use-case and
hence, maybe we should keep both at `info` level? Stacktrace is also equally
interesting right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
