bharathv commented on a change in pull request #6:
URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r471172402
##########
File path: CMakeLists.txt
##########
@@ -284,23 +304,13 @@ target_link_libraries(hbaseclient-shared ${CMAKE_DL_LIBS})
add_executable(simple-client "${HBASE_SRC_DIR}/examples/simple-client.cc")
set_target_properties(simple-client PROPERTIES COMPILE_FLAGS " ")
set_target_properties(simple-client PROPERTIES RUNTIME_OUTPUT_DIRECTORY
"${CMAKE_CURRENT_BINARY_DIR}/bin/examples")
-target_link_libraries(simple-client ${PROTOBUF_LIBRARY})
-target_link_libraries(simple-client ${Boost_LIBRARIES})
-target_link_libraries(simple-client ${SASL_LIBS})
-target_link_libraries(simple-client ${GFLAGS_SHARED_LIB})
-target_link_libraries(simple-client ${KRB5_LIBRARIES})
-target_link_libraries(simple-client ${ZOOKEEPER_LIBRARIES})
target_link_libraries(simple-client hbaseclient-static
${CMAKE_THREAD_LIBS_INIT})
+target_link_libraries(simple-client ${WHOLE_ARCHIVE} ${Boost_context}
${NO_WHOLE_ARCHIVE})
Review comment:
Cool, fine to do a follow on patch.
##########
File path: cmake/patches/fizz.v2020.05.18.00.cmake
##########
@@ -0,0 +1,18 @@
+36c36
+< find_package(folly CONFIG REQUIRED)
+---
+> find_package(Folly REQUIRED)
+46a47,54
+>
+> if(NOT APPLE)
+> if(NOT WIN32)
Review comment:
No worries, was just curious. ya, if (LINUX) would be simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
