bitoffdev commented on a change in pull request #2282:
URL: https://github.com/apache/hbase/pull/2282#discussion_r474204114



##########
File path: hbase-shell/src/main/ruby/shell/commands/list_peers.rb
##########
@@ -38,10 +38,10 @@ def help
       def command
         peers = replication_admin.list_peers
 
-        formatter.header(%w[PEER_ID CLUSTER_KEY ENDPOINT_CLASSNAME
+        table_formatter.start_table({ num_cols: 11, headers: %w[PEER_ID 
CLUSTER_KEY ENDPOINT_CLASSNAME

Review comment:
       `num_cols` isn't needed. It is derived from headers and widths by 
TableFormatter. I just updated the patch to remove `num_cols` from all the 
places that unnecessarily specified it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to