[GitHub] [hbase] infraio commented on a change in pull request #2292: HBASE-24928 balanceRSGroup should skip generating balance plan for disabled table

[GitBox]

infraio commented on a change in pull request #2292:
URL: https://github.com/apache/hbase/pull/2292#discussion_r475166414



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -1064,19 +1065,26 @@ private boolean isTableInGroup(TableName tableName, 
String groupName,
     return rit;
   }
 
-  private Map<TableName, Map<ServerName, List<RegionInfo>>> 
getRSGroupAssignmentsByTable(
-      String groupName) throws IOException {
+  @VisibleForTesting
+  Map<TableName, Map<ServerName, List<RegionInfo>>> 
getRSGroupAssignmentsByTable(

Review comment:
       This method will be called when balance? Add some comments here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org