[ 
https://issues.apache.org/jira/browse/HBASE-24764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186587#comment-17186587
 ] 

Wellington Chevreuil edited comment on HBASE-24764 at 8/28/20, 2:52 PM:
------------------------------------------------------------------------

Thanks for the contribution, [~jainankit]. Can you please submit your patch as 
a github PR? That's way easier to follow up on reviews and track discussions 
about a patch, and it's the standard approach used in hbase for a while now.


was (Author: wchevreuil):
Thanks for the contribution, [~jainankit]. Can you please submit your patch as 
a github PR? That's way easy to follow up on reviews and track discussions 
about a patch, and it's the standard approach used in hbase for a while now.

> Add support of adding base peer configs via hbase-site.xml for all 
> replication peers.
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-24764
>                 URL: https://issues.apache.org/jira/browse/HBASE-24764
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ankit Jain
>            Assignee: Ankit Jain
>            Priority: Minor
>         Attachments: HBASE-24764-master.patch
>
>
> Today, if a user needs to apply some common base peer configs to all the 
> replication peers on a given cluster, the only way is to execute 
> update_peer_config via CLI which requires manual intervention and can be 
> tedious in case of large deployment fleet.
> As part of this JIRA, we plan to add the support to have base replication 
> peer configs as part of hbase-site.xml like 
> hbase.replication.peer.base.config="k1=v1;k2=v2.." which can be easily 
> updated and applied as part of a rolling restart. Example below:
>  <property>
>  <name>hbase.replication.peer.base.configs</name>
>  
> <value>hbase.replication.source.custom.walentryfilters=x,y,z;hbase.rpc.protection=abc;hbase.xxx.custom_property=123</value>
>  </property>
> This will be empty by default, but one can override to have base configs in 
> place.
> The final peer configuration would be a merge of this newly added base config 
> + whatever users override during the peer creation/update (if any).
> Related Jira: https://issues.apache.org/jira/browse/HBASE-17543.  HBASE-17543 
> added the support to add the WALEntryFilters to default endpoint via peer 
> configuration. By this new Jira we are extending the support to update peer 
> configs via hbase-site.xml.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to