saintstack commented on a change in pull request #2322:
URL: https://github.com/apache/hbase/pull/2322#discussion_r479792558
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -968,6 +968,19 @@ private RegionLocations locateRegionInMeta(TableName
tableName, byte[] row, bool
}
}
+ private void takeUserRegionLock() throws IOException {
+ try {
+ long waitTime = connectionConfig.getScannerTimeoutPeriod();
+ if (!userRegionLock.tryLock(waitTime, TimeUnit.MILLISECONDS)) {
Review comment:
`My concern was from a user configuration POV, there 3 or 4 different
timeouts a user has to configure (depending on which API they are using) to get
a proper timeout behavior. Ideally it'd be nice if there is a single timeout at
the root level that is an e-e timeout and probably other timeouts like scanner
timeout etc for finer control depending on the need.`
This is a critical concern. Our @petersomogyi was the last to throw himself
against this rampart. The work is not yet finished. Yes, to a new issue.
Here will wait on @infraio 's input.....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
