[
https://issues.apache.org/jira/browse/HBASE-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267771#comment-13267771
]
Phabricator commented on HBASE-5494:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5494] [89-fb] Table-level
locks for schema changing operations.".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/master/TableLockManager.java:137 Is
there a chance that acquiredTableLocks is out of sync with the lock status up
in zk ?
src/main/java/org/apache/hadoop/hbase/zookeeper/DistributedLock.java:87 Add a
space after 'wait'
src/main/java/org/apache/hadoop/hbase/zookeeper/DistributedLock.java:104 Do
we really need this exception ?
src/main/java/org/apache/hadoop/hbase/zookeeper/DistributedLock.java:111
Please include lockZNodeVersion here.
src/main/java/org/apache/hadoop/hbase/zookeeper/DistributedLock.java:180
fullyQualifiedZNode should be included.
src/main/java/org/apache/hadoop/hbase/zookeeper/DistributedLock.java:292
Please include fullyQualifiedZNode
src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java:1310
Please make the second part of the sentence correct
src/main/java/org/apache/hadoop/hbase/util/InjectionHandler.java:144 Can this
method be made non-public ?
REVISION DETAIL
https://reviews.facebook.net/D2997
> Introduce a zk hosted table-wide read/write lock so only one table operation
> at a time
> --------------------------------------------------------------------------------------
>
> Key: HBASE-5494
> URL: https://issues.apache.org/jira/browse/HBASE-5494
> Project: HBase
> Issue Type: Improvement
> Reporter: stack
> Attachments: D2997.3.patch
>
>
> I saw this facility over in the accumulo code base.
> Currently we just try to sort out the mess when splits come in during an
> online schema edit; somehow we figure we can figure all possible region
> transition combinations and make the right call.
> We could try and narrow the number of combinations by taking out a zk table
> lock when doing table operations.
> For example, on split or merge, we could take a read-only lock meaning the
> table can't be disabled while these are running.
> We could then take a write only lock if we want to ensure the table doesn't
> change while disabling or enabling process is happening.
> Shouldn't be too hard to add.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
