joshelser commented on a change in pull request #14:
URL: https://github.com/apache/hbase-filesystem/pull/14#discussion_r480416248
##########
File path:
hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java
##########
@@ -121,9 +120,26 @@ private void waitForCuratorToConnect() {
}
@Override
- public void close() throws IOException {
+ public void close() {
if (curator != null) {
- curator.close();
+ synchronized(this) {
+ curator.close();
+ lockCache.clear();
+ logCaller();
Review comment:
Checked CuratorFrameworkImpl and am happy to see that multiple calls to
close() are OK to make.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
