[ 
https://issues.apache.org/jira/browse/HBASE-24921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190660#comment-17190660
 ] 

Abhey Rana commented on HBASE-24921:
------------------------------------

[~ndimiduk] I was exploring the code-base for the making required changes, And 
I have a question related to the overall scope of this JIRA.

As part of this JIRA, Do I just need to add help for the _magic commands_, Or I 
need to also move the actual implementation of these _magic commands_ to the 
newly created classes?

Like _debug_ is a flag currently defined in 
[hirb.rb|https://github.com/apache/hbase/blob/master/bin/hirb.rb#L172], So do I 
also need to refactor the implementation, So as to define similar behaviour in 
the new _debug.rb_ that I will create as part of this work?

Please do not mind, If this is a novice question. I am just starting my journey 
of HBase project contribution :)

> Add help output for shell "magic" commands
> ------------------------------------------
>
>                 Key: HBASE-24921
>                 URL: https://issues.apache.org/jira/browse/HBASE-24921
>             Project: HBase
>          Issue Type: Improvement
>          Components: shell
>            Reporter: Nick Dimiduk
>            Assignee: Abhey Rana
>            Priority: Major
>
> The shell has a handful of "magic" commands, things like {{help}} and 
> {{debug}}, that exist as commands in the shell, but are not implementations 
> of the command class and have no help documentation of their own.
> Let's promote them to proper commands, add a new command group, call it 
> "shell command group", for example. This makes them discoverable. Give each 
> of them a help documentation string with examples, as we have for the others, 
> i.e., {{help 'help'}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to