sandeepvinayak commented on a change in pull request #2345:
URL: https://github.com/apache/hbase/pull/2345#discussion_r483837925
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
##########
@@ -274,7 +287,8 @@ public void processFile(final Configuration conf, final
Path p)
Map<String, Object> txn = key.toStringMap();
long writeTime = key.getWriteTime();
// check output filters
- if (table != null && !((TableName)
txn.get("table")).toString().equals(table)) {
+ if (!tableSet.isEmpty() &&
Review comment:
I think we need the first one where we don't pass `-t` param and set is
Empty. In that case, the second one will always skip all the tables.
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
##########
@@ -274,7 +287,8 @@ public void processFile(final Configuration conf, final
Path p)
Map<String, Object> txn = key.toStringMap();
long writeTime = key.getWriteTime();
// check output filters
- if (table != null && !((TableName)
txn.get("table")).toString().equals(table)) {
+ if (!tableSet.isEmpty() &&
Review comment:
I think we need the first one where we don't pass `-t` param and set is
Empty. In that case, the second one will always skip all the tables. @bharathv
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
