wchevreuil commented on a change in pull request #75:
URL: 
https://github.com/apache/hbase-operator-tools/pull/75#discussion_r484808209



##########
File path: hbase-tools/src/test/java/org/apache/hbase/TestRegionsMerger.java
##########
@@ -132,6 +138,27 @@ public void testMergeRegionsInvalidParams() throws 
Exception {
         originalCount, TEST_UTIL.countRows(table));
   }
 
+  @Test
+  public void testRegionHasNoState() throws Exception {
+    // Turn on the replication of the table, and then merge two regions, the 
parent regions will
+    // not have the column info:state in the meta table, only the column
+    // rep_barrier:seqnumDuringOpen is left. And we should skip the parent 
regions.
+    TableDescriptor tableDesc = TEST_UTIL.getAdmin().getDescriptor(TABLE_NAME);
+    
TEST_UTIL.getAdmin().modifyTable(TableDescriptorBuilder.newBuilder(tableDesc).

Review comment:
       Why setting replication scope in this test? Do we need to set 
replication scope in order to reproduce the "no state info" condition?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to