[ 
https://issues.apache.org/jira/browse/HBASE-24994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194377#comment-17194377
 ] 

Hudson commented on HBASE-24994:
--------------------------------

Results for branch branch-1
        [build #23 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/23/]:
 (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/23//General_Nightly_Build_Report/]


(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/23//JDK7_Nightly_Build_Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/23//JDK8_Nightly_Build_Report_(Hadoop2)/]




(x) {color:red}-1 source release artifact{color}
-- See build output for details.


> Add hedgedReadOpsInCurThread metric
> -----------------------------------
>
>                 Key: HBASE-24994
>                 URL: https://issues.apache.org/jira/browse/HBASE-24994
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Javier Akira Luca de Tena
>            Assignee: Javier Akira Luca de Tena
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 1.7.0, 2.4.0
>
>
> When adding Hedged Reads metrics at 
> https://issues.apache.org/jira/browse/HBASE-12220, hedgedReadOpsInCurThread 
> was not included.
> I wonder if there was any reason to not include them. If not, I will provide 
> pull request to include them soon.
>  
> Hedged reads use same thread pool for the original read:
>  
> [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java#L1349-L1357]
>  When the executor is full and rejects the task, it will be executed in 
> current thread, increasing this metric:
>  
> [https://github.com/apache/hadoop/blob/0b8464d75227fcee2c6e7f2410377b3d53d3d5f8/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSClient.java#L2913-L2918]
> This metric is very useful to determine if the hedged reads thread pool 
> (dfs.client.hedged.read.threadpool.size) is undersized.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to