[ 
https://issues.apache.org/jira/browse/HBASE-24831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196073#comment-17196073
 ] 

Viraj Jasani edited comment on HBASE-24831 at 9/15/20, 11:38 AM:
-----------------------------------------------------------------

Reopening since this is breaking source compatibility by removing protected 
methods of IA.Public org.apache.hadoop.hbase.mapreduce.TableRecordReaderImpl.

Checked PR discussion but compatibility is not mentioned. Maybe an oversight?

FYI [~zhangduo] [~zghao] [~ndimiduk]


was (Author: vjasani):
Reopening since this is breaking source compatibility by removing protected 
methods of IA.Public org.apache.hadoop.hbase.mapreduce.TableRecordReaderImpl.

Checked PR discussion but compatibility is not mentioned. Maybe an oversight?

> Avoid invoke Counter using reflection  in SnapshotInputFormat
> -------------------------------------------------------------
>
>                 Key: HBASE-24831
>                 URL: https://issues.apache.org/jira/browse/HBASE-24831
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Yechao Chen
>            Assignee: Yechao Chen
>            Priority: Major
>              Labels: Performance, mapreduce, snapshot
>             Fix For: 3.0.0-alpha-1, 2.4.0, 2.3.2
>
>
> In TableRecordReaderImpl we invoke Counter increment by reflection
> This will be called nextKeyValue() in TableSnapshotInputFormat 
> reflection invoke is very slower than normal method call
> we can avoid these to improve the read performance



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to