Reidddddd commented on a change in pull request #2396:
URL: https://github.com/apache/hbase/pull/2396#discussion_r489154603
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
##########
@@ -5028,73 +5028,70 @@ public void testCheckAndDeleteWithCompareOp() throws
IOException, InterruptedExc
FAMILY);
TEST_UTIL.waitTableAvailable(TableName.valueOf("testCheckAndDeleteWithCompareOp"),
10000);
- Put put2 = new Put(ROW);
- put2.add(FAMILY, QUALIFIER, value2);
- table.put(put2);
+ Put bbbb = new Put(ROW);
+ bbbb.add(FAMILY, QUALIFIER, value2);
- Put put3 = new Put(ROW);
- put3.add(FAMILY, QUALIFIER, value3);
+ Put cccc = new Put(ROW);
+ cccc.add(FAMILY, QUALIFIER, value3);
Delete delete = new Delete(ROW);
delete.deleteColumns(FAMILY, QUALIFIER);
// cell = "bbbb", using "aaaa" to compare only LESS/LESS_OR_EQUAL/NOT_EQUAL
// turns out "match"
+ table.put(bbbb);
boolean ok = table.checkAndDelete(ROW, FAMILY, QUALIFIER,
CompareOp.GREATER, value1, delete);
- assertEquals(ok, false);
+ // aaaa is less than bbbb, > || >= should be false
+ assertFalse(ok);
ok = table.checkAndDelete(ROW, FAMILY, QUALIFIER, CompareOp.EQUAL, value1,
delete);
- assertEquals(ok, false);
+ assertFalse(ok);
ok = table.checkAndDelete(ROW, FAMILY, QUALIFIER,
CompareOp.GREATER_OR_EQUAL, value1, delete);
- assertEquals(ok, false);
+ assertFalse(ok);
+ // aaaa is less than bbbb, < || <= should be true
ok = table.checkAndDelete(ROW, FAMILY, QUALIFIER, CompareOp.LESS, value1,
delete);
- assertEquals(ok, true);
- table.put(put2);
+ assertTrue(ok);
+ table.put(bbbb);
ok = table.checkAndDelete(ROW, FAMILY, QUALIFIER, CompareOp.LESS_OR_EQUAL,
value1, delete);
- assertEquals(ok, true);
- table.put(put2);
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
