[
https://issues.apache.org/jira/browse/HBASE-25037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196814#comment-17196814
]
Viraj Jasani commented on HBASE-25037:
--------------------------------------
{code:java}
if (!t.isDaemon()) {
t.setDaemon(true);
}{code}
Everyone using previous utility always used to have daemon mode on. To maintain
the same behaviour, I agree that we will have to update all thread factories to
use daemon threads.
> Lots of thread pool are changed to non daemon after HBASE-24750 which causes
> trouble when shutting down
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-25037
> URL: https://issues.apache.org/jira/browse/HBASE-25037
> Project: HBase
> Issue Type: Improvement
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> We replace Threads.newDaemonThreadFactory with guava ThreadFactoryBuilder but
> miss the setDaemon call, which causes our client integration test to fail
> because of hbase shell can never quit cleanly.
> We should add the setDaemon back for those thread factories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
