Joseph295 commented on pull request #2408:
URL: https://github.com/apache/hbase/pull/2408#issuecomment-693419914
> Why missing incrementing could lead to negative count? How do we calculate
the number on web UI?
The wrong info is from the following:
` String countsStr = (editsCount - (editsSkipped +
outputSink.getTotalSkippedEdits()))
+ " edits, skipped " + editsSkipped + " edits.";`
Here is my understanding, correct me if I am wrong:
The editsCount is the count of all edits, editsSkipped is the count of
skipped edits before sinking, outputSink.getTotalSkippedEdits() is the skipped
edits when sinking. So the later two: editsSkipped and
outputSink.getTotalSkippedEdits() are parts of editsCount.But in our current
repo, we will miss incrementing editsCount when skipping edits condition fits
, as we continue and run the next loop and the increment is not executed yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
