[
https://issues.apache.org/jira/browse/HBASE-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197343#comment-17197343
]
Hudson commented on HBASE-24750:
--------------------------------
Results for branch master
[build #51 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/51/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/51/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/51/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/51/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/51//artifact/output-integration/hadoop-2.log].
(note that this means we didn't run on Hadoop 3)
> All executor service should start using guava ThreadFactory
> -----------------------------------------------------------
>
> Key: HBASE-24750
> URL: https://issues.apache.org/jira/browse/HBASE-24750
> Project: HBase
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Currently, we have majority Executor services using guava's
> ThreadFactoryBuilder while creating fixed size thread pool. There are some
> executors using our internal hbase-common's Threads class which provides util
> methods for creating thread factory.
> Although there is no perf impact, we should let all Executors start using our
> internal library for using ThreadFactory rather than having external guava
> dependency (which is nothing more than a builder class). We might have to add
> a couple more arguments to support full fledged ThreadFactory, but let's do
> it and stop using guava's builder class.
> *Update:*
> Based on the consensus, we should use only guava library and retire our
> internal code which maintains ThreadFactory creation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
