[
https://issues.apache.org/jira/browse/HBASE-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268569#comment-13268569
]
Hadoop QA commented on HBASE-5584:
----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525649/HBASE-5584-3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop23. The patch compiles against the hadoop 0.23.x profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/1767//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/1767//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/1767//console
This message is automatically generated.
> Coprocessor hooks can be called in the respective handlers
> ----------------------------------------------------------
>
> Key: HBASE-5584
> URL: https://issues.apache.org/jira/browse/HBASE-5584
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.96.0
>
> Attachments: HBASE-5584-1.patch, HBASE-5584-2.patch,
> HBASE-5584-3.patch, HBASE-5584.patch
>
>
> Following points can be changed w.r.t to coprocessors
> -> Call preCreate, postCreate, preEnable, postEnable, etc. in their
> respective handlers
> -> Currently it is called in the HMaster thus making the postApis async w.r.t
> the handlers
> -> Similar is the case with the balancer.
> with current behaviour once we are in the postEnable(for eg) we any way need
> to wait for the main enable handler to
> be completed.
> We should ensure that we dont wait in the main thread so again we need to
> spawn a thread and wait on that.
> On the other hand if the pre and post api is called on the handlers then only
> that handler thread will be
> used in the pre/post apis
> If the above said plan is ok i can prepare a patch for all such related
> changes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
