ramkrish86 commented on a change in pull request #2419:
URL: https://github.com/apache/hbase/pull/2419#discussion_r491815268
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
##########
@@ -85,8 +85,6 @@ public HFileSystem(Configuration conf, boolean
useHBaseChecksum)
this.fs = FileSystem.get(conf);
this.useHBaseChecksum = useHBaseChecksum;
- fs.initialize(getDefaultUri(conf), conf);
-
Review comment:
Sure @busbey we can change it. but pls do remember that this get() call
- what ever flavor of the FS#get() we do, we have already done a call to the
FS#get even before we do the HFileSystem creation.
`public static Path getWALRootDir(final Configuration c) throws IOException {
Path p = new Path(c.get(HBASE_WAL_DIR, c.get(HConstants.HBASE_DIR)));
if (!isValidWALRootDir(p, c)) {
return getRootDir(c);
}
FileSystem fs = p.getFileSystem(c);
return p.makeQualified(fs.getUri(), fs.getWorkingDirectory());
}
`
when we do p.getFileSystem() we have inited the file system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
