[
https://issues.apache.org/jira/browse/HBASE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268785#comment-13268785
]
jirapos...@reviews.apache.org commented on HBASE-5889:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4993/
-----------------------------------------------------------
(Updated 2012-05-04 22:54:46.398933)
Review request for hbase.
Summary
-------
Removed HRegionInterface, and cleaned up the HRegionServer, moved pb code from
RegionServer back to HRegionServer.
The goal is to avoid two copies of region server code to maintain, and make it
possible to avoid data type conversion in the sever side.
Fixed some unit tests. Now all region server unit tests test the new pb
functions.
Enhanced getServerInfo so that it returns the webui port too.
This addresses bug HBASE-5889.
https://issues.apache.org/jira/browse/HBASE-5889
Diffs (updated)
-----
conf/hbase-policy.xml e45f23c
security/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java
fda40cc
src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon
87f04f4
src/main/java/org/apache/hadoop/hbase/HConstants.java a9d80a0
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java e3912c2
src/main/java/org/apache/hadoop/hbase/ipc/HBaseRpcMetrics.java fc9176d
src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 757f98e
src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java
cd9b528
src/main/java/org/apache/hadoop/hbase/master/CatalogJanitor.java 79d5fdd
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 6ba8ab0
src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java 212ee3e
src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java d1e0993
src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java 81603af
src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java
fbf0127
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
db1333b
src/main/java/org/apache/hadoop/hbase/protobuf/generated/HBaseProtos.java
ae2094d
src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java
8b45f03
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
827fb23
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 8c8381b
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionThriftServer.java
4cb070e
src/main/java/org/apache/hadoop/hbase/regionserver/RegionServer.java c2c89ea
src/main/protobuf/Admin.proto 2ad6fb0
src/main/protobuf/RPC.proto 105fb3f
src/main/resources/hbase-default.xml f54b345
src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java a1992c3
src/test/java/org/apache/hadoop/hbase/TestGlobalMemStoreSize.java ad77e0a
src/test/java/org/apache/hadoop/hbase/TestRegionRebalancing.java 5574b7f
src/test/java/org/apache/hadoop/hbase/catalog/TestCatalogTracker.java 3dfc94e
src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
42092b7
src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java c270e28
src/test/java/org/apache/hadoop/hbase/client/TestMultiParallel.java c36272f
src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
bdec3ee
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
7dbba66
src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
3acb988
src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
eb546a5
src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java ceba5cd
src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java
ec08b17
src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java 30c6cf1
src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java
8c3f67e
src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java
7bfe4cd
src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java
ffce7e8
src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java
aa5ca37
src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
65fa948
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java fc4a0a7
Diff: https://reviews.apache.org/r/4993/diff
Testing
-------
All regular and security profile tests are green before I rebased to the latest
today.
Thanks,
Jimmy
> Remove HRegionInterface
> -----------------------
>
> Key: HBASE-5889
> URL: https://issues.apache.org/jira/browse/HBASE-5889
> Project: HBase
> Issue Type: Improvement
> Components: client, ipc, regionserver
> Affects Versions: 0.96.0
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5889_v3.patch, hbase_5889.patch,
> hbase_5889_v2.patch, hbase_5889_v4.patch
>
>
> As a step to move internals to PB, so as to avoid the conversion for
> performance reason, we should remove the HRegionInterface.
> Therefore region server only supports ClientProtocol and AdminProtocol.
> Later on, HRegion can work with PB messages directly.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
