Apache9 commented on a change in pull request #2449:
URL: https://github.com/apache/hbase/pull/2449#discussion_r494849980
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java
##########
@@ -418,6 +419,30 @@ public static boolean isMetaFile(String p) {
return p != null && p.endsWith(META_WAL_PROVIDER_ID);
}
+ /**
+ * Comparator used to compare logs together based on their start time.
+ * Just compares start times and nothing else.
+ */
+ public static class WALsStartTimeComparator implements Comparator<Path> {
Review comment:
I mean is it better to change 'WALs' to 'WALFile'? Or at least to 'WAL'?
'WALs' looks strange...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
