Apache9 commented on a change in pull request #2448:
URL: https://github.com/apache/hbase/pull/2448#discussion_r494997282
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/CatalogFamilyFormat.java
##########
@@ -101,7 +101,7 @@ public static RegionInfo
parseRegionInfoFromRegionName(byte[] regionName) throws
long regionId = Long.parseLong(Bytes.toString(fields[2]));
int replicaId = fields.length > 3 ?
Integer.parseInt(Bytes.toString(fields[3]), 16) : 0;
return
RegionInfoBuilder.newBuilder(TableName.valueOf(fields[0])).setStartKey(fields[1])
-
.setEndKey(fields[2]).setSplit(false).setRegionId(regionId).setReplicaId(replicaId).build();
+ .setSplit(false).setRegionId(regionId).setReplicaId(replicaId).build();
Review comment:
I think the setSplit(false) could also be removed. The default value is
false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
