Apache9 commented on a change in pull request #955:
URL: https://github.com/apache/hbase/pull/955#discussion_r495522091
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureScheduler.java
##########
@@ -135,7 +139,11 @@ protected void enqueue(final Procedure proc, final boolean
addFront) {
doAdd(tableRunQueue, getTableQueue(getTableName(proc)), proc, addFront);
} else if (isServerProcedure(proc)) {
ServerProcedureInterface spi = (ServerProcedureInterface) proc;
- doAdd(serverRunQueue, getServerQueue(spi.getServerName(), spi), proc,
addFront);
+ if (spi.hasMetaTableRegion()) {
+ doAdd(serverHighPriorityRunQueue, getServerQueue(proc), proc,
addFront);
Review comment:
IIRC, there is a problem that, the sub procedures will inherit some
resources from the parent procedure, so changing the logic here is easy to
introduce dead lock...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
