huaxiangsun commented on a change in pull request #2468:
URL: https://github.com/apache/hbase/pull/2468#discussion_r496295697



##########
File path: 
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java
##########
@@ -225,8 +245,10 @@ public void map(WALKey key, WALEdit value, Context context)
                 }
               }
               if (CellUtil.isDelete(cell)) {
+                context.getCounter(Counter.CELLS_WRITTEN).increment(1);
                 del.add(cell);
               } else {
+                context.getCounter(Counter.CELLS_WRITTEN).increment(1);
                 put.add(cell);

Review comment:
       Nit, can the above 
"context.getCounter(Counter.CELLS_WRITTEN).increment(1);" be moved of the if {} 
else {}?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to