ndimiduk commented on a change in pull request #2163:
URL: https://github.com/apache/hbase/pull/2163#discussion_r498557359
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/QuotaObserverChore.java
##########
@@ -566,6 +566,13 @@ void setTableQuotaSnapshot(TableName table,
SpaceQuotaSnapshot snapshot) {
this.tableQuotaSnapshots.put(table, snapshot);
}
+ /**
+ * Removes the quota state for the given table.
+ */
+ void removeTableQuotasnapshot(TableName table) {
+ this.tableQuotaSnapshots.remove(table);
Review comment:
I think you need some synchronization around modifications to this data
structure. If I understand correctly, the Chore will be run in it's own thread,
while quota changes would be dispatched from an IPC handler thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
