[
https://issues.apache.org/jira/browse/HBASE-25091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206047#comment-17206047
]
Hudson commented on HBASE-25091:
--------------------------------
Results for branch master
[build #76 on
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/76/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/76/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 3. [see log for
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/76//artifact/output-integration/hadoop-3.log].
(note that this means we didn't check the Hadoop 3 shaded client)
> Move LogComparator from ReplicationSource to
> AbstractFSWALProvider#.WALsStartTimeComparator
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-25091
> URL: https://issues.apache.org/jira/browse/HBASE-25091
> Project: HBase
> Issue Type: Improvement
> Reporter: Michael Stack
> Assignee: Michael Stack
> Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> Minor cleanup item noticed playing over in HBASE-18070.
> ReplicationSource has an inner class named LogComparator which is a pretty
> generic name for the comparator only it just compares on WAL start time and
> nothing else.
> Also, messing in HBASE-18070 I ran into compares that included user-space
> WALs and hbase:meta WALs. The LogComparator as is barfed on meta WALs.
> This ticket moves the comparator to AbstractFSWALProvider, where folks will
> go looking if they need WAL comparators, and it also renames it to more
> clearly explain what it does (and makes it so it can compare start times even
> if it a meta WAL).
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
