huaxiangsun commented on pull request #2451: URL: https://github.com/apache/hbase/pull/2451#issuecomment-702790612
> > This seems like a bug. I can file a follow-on to write a test to repro and to fix? Yeah, that is what I read from the code. A follow-on is good as we can create a unitest to show if the issue really exists. > > > It will be better that the source can be removed and re-added back when meta region is moved back, it is much cleaner. > > This I think this could prove difficult if split meta and for some reason, many meta Regions on a single server w/ some opening and come closing. The open/close are each in their own handlers so could end up making for some interesting create/destroy scenarios. Keeping up the ReplicationSource once created seems easy to reason about. Agreed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
