[ https://issues.apache.org/jira/browse/HBASE-25145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206647#comment-17206647 ]
Michael Stack commented on HBASE-25145: --------------------------------------- I wrote a test and it doesn't look like WALReader thread quits. It stays up as long as there is a WAL around – as per [~zhangduo] above – which will be the case given how HBASE-25055 is implemented. Let me try some more. Shout if you have a pointer on what to look at [~huaxiangsun] - thanks. (The test did find a good issue – see HBASE-25151) > WALReader quits if nothing to replicate (and won't restart) > ----------------------------------------------------------- > > Key: HBASE-25145 > URL: https://issues.apache.org/jira/browse/HBASE-25145 > Project: HBase > Issue Type: Sub-task > Reporter: Michael Stack > Priority: Major > > Noticed by [~huaxiangsun] in his review of HBASE-25055 "Add ReplicationSource > for meta WALs; add enable/disable w…" > {quote}bq. Eventually, the meta wal file will be gced and there is no more > logs in the queue. In that case, the walReader thread will quit. When the > meta region is moved back, it does not seem that walReader thread will be > restarted. So it seems that something is broken. > {quote} > This issue is about writing a test to run the above scenario and fix any > probs. found. -- This message was sent by Atlassian Jira (v8.3.4#803005)