virajjasani commented on a change in pull request #2494:
URL: https://github.com/apache/hbase/pull/2494#discussion_r499247076
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java
##########
@@ -224,6 +225,9 @@ protected void serializeStateData(ProcedureStateSerializer
serializer) throws IO
ReopenTableRegionsStateData.Builder builder =
ReopenTableRegionsStateData.newBuilder()
.setTableName(ProtobufUtil.toProtoTableName(tableName));
regions.stream().map(ProtobufUtil::toRegionLocation).forEachOrdered(builder::addRegion);
+ if (CollectionUtils.isNotEmpty(regionNames)) {
Review comment:
Let it be for backward compat?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ReopenTableRegionsProcedure.java
##########
@@ -234,5 +238,12 @@ protected void
deserializeStateData(ProcedureStateSerializer serializer) throws
tableName = ProtobufUtil.toTableName(data.getTableName());
regions = data.getRegionList().stream().map(ProtobufUtil::toRegionLocation)
.collect(Collectors.toList());
+ if (CollectionUtils.isNotEmpty(data.getRegionNamesList())) {
Review comment:
Sure, will use collect here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
