saintstack commented on a change in pull request #1727:
URL: https://github.com/apache/hbase/pull/1727#discussion_r501399549
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
##########
@@ -593,6 +618,33 @@ private void printMeta(HFile.Reader reader, Map<byte[],
byte[]> fileInfo)
} else {
out.println(FOUR_SPACES + "Not present");
}
+ DoublesSketch keySizeSketch =
+ getDoublesSketchFromMetaBlock(reader,
HFileWriterImpl.KEYSIZE_SKETCH_KEY_STR);
+ printDoublesSketch(keySizeSketch, "keySize");
+ DoublesSketch valueSizeSketch =
+ getDoublesSketchFromMetaBlock(reader,
HFileWriterImpl.VALUESIZE_SKETCH_KEY_STR);
+ printDoublesSketch(valueSizeSketch, "valueSize");
+ }
+
+ private void printDoublesSketch(DoublesSketch sketch, String name) {
+ double [] quantiles = sketch.getQuantiles(NORMALIZED_RANKS);
Review comment:
I like the every quantile. Doesn't cost and user can pick what quantile
they want to view.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
