VictorZeng commented on pull request #77: URL: https://github.com/apache/hbase-operator-tools/pull/77#issuecomment-705925637
> > > > There is no `HbckService` in versions of hbase _before 2.0.3 and 2.1.1_. HBCK2 will not work against these versions. If users use Hbase 2.1.0 version, you can use this tool to repair metadata. > > > > > > > > > Have you tried use these functions and got some error? If so, we should fix that, as neither `addFsRegionsMissingInMeta` nor `extraRegionsInMeta` rely on HbckService, they perform fixes on their own, thus, there should be no hbase version validation when using these two functions, and they should be compatible with the above versions. > > > > > > Hi wchevreuil, although both `addFsRegionsMissingInMeta` and `extraRegionsInMeta` do not rely on HbckService, but `assigns` command rely on HbckService... So I think this tool is very useful. > > > Hi wchevreuil, although both `addFsRegionsMissingInMeta` and `extraRegionsInMeta` do not rely on HbckService, but `assigns` command rely on HbckService... So I think this tool is very useful. > > Then the only extra bit is a bulk assignment? Could it reuse `addFsRegionsMissingInMeta` and `extraRegionsInMeta`, instead of providing extra lines of code that do same as the already existing methods? I do agree the command proposed here is very convenient, but we should re-use already existing code as much as possible. This tool function is more similar to the hbck1 `fixMeta` command, it can repair the metadata when users are deploying a 2.x version without HBCK2 support more quickly and conveniently. So it's necessary to provide extra codes. I think it's better to be independent. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
