ramkrish86 commented on a change in pull request #2483:
URL: https://github.com/apache/hbase/pull/2483#discussion_r501603864



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScanner.java
##########
@@ -115,4 +116,6 @@
    */
   boolean nextRaw(List<Cell> result, ScannerContext scannerContext)
       throws IOException;
+
+  boolean isFullRegionScan();

Review comment:
       If we are doing this way - then I think it is better to have the default 
implementation in the interface returning 'false'. So that the downstreamers 
need not change this code. I think it is still better to have this check in RS 
(like a Util method)only rather than here because this will have an impact on 
projects like Phoenix. (because RegionScanner is exposed to CP).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to