[
https://issues.apache.org/jira/browse/HBASE-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270020#comment-13270020
]
stack commented on HBASE-5806:
------------------------------
@Chinna Very nice work. Thanks. I can wrap the long lines on commit. Here's
some questions on the patch just out of interest:
{code}
- JVMClusterUtil.MasterThread mt =
- JVMClusterUtil.createMasterThread(c,
- this.masterClass, index);
+ JVMClusterUtil.MasterThread mt = JVMClusterUtil.createMasterThread(c,
+ (Class<? extends HMaster>) c.getClass(HConstants.MASTER_IMPL,
HMaster.class), index);
this.masterThreads.add(mt);
{code}
What brought on the above change? Was this needed so you could add your
mocking tests or is it that you fellas are doing a master subclass?
I don't understand why we need this change (because of hbase-5654 ?):
{code}
default:
- throw new IllegalStateException("Received event is not valid.");
+ break;
}
{code}
Log that we are going to pass on a region here?
{code}
+ // If znode does not exist dont consider this region
+ if (data == null) {
+ continue;
+ }
{code}
At debug level?
> Handle split region related failures on master restart and RS restart
> ---------------------------------------------------------------------
>
> Key: HBASE-5806
> URL: https://issues.apache.org/jira/browse/HBASE-5806
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: Chinna Rao Lalam
> Fix For: 0.92.2, 0.96.0, 0.94.1
>
> Attachments: HBASE-5806.patch, HBASE-5806_0.94.patch,
> HBASE-5806_0.94_1.patch, HBASE-5806_trunk.patch, HBASE-5806_trunk_1.patch
>
>
> This issue is raised to solve issues that comes out of partial region split
> happened and the region node in the ZK which is in RS_ZK_REGION_SPLITTING and
> RS_ZK_REGION_SPLIT is not yet processed.
> This also tries to address HBASE-5615.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
