Apache9 commented on pull request #2495: URL: https://github.com/apache/hbase/pull/2495#issuecomment-706525416
> > The interface is IA.Public so you can not change the methd signature directly... > > @Apache9 I agree with the point that the IA.Public interface couldn't change the signature. But my confusion is that current behavior of `getStartEndKeys` basic method doesn't throw `IOException`, therefore doesn't need to wrapper `IOException` into `CompletableFuture`. In the async context, we will not throw Exception directly in code, instead we will use CompletableFuture.completeExceptionally to propagate the Exception. This is what I mean 'wrap the IOException with CompletableFuture'. In general, we will call master through rpc when executing getStartEndKeys so obvious we could meet IOException. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
