Apache9 commented on a change in pull request #2450:
URL: https://github.com/apache/hbase/pull/2450#discussion_r502911376
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
##########
@@ -2150,12 +2150,8 @@ private void acceptPlan(final HashMap<RegionInfo,
RegionStateNode> regions,
final ProcedureEvent<?>[] events = new ProcedureEvent[regions.size()];
final long st = System.currentTimeMillis();
- if (plan == null) {
- throw new HBaseIOException("unable to compute plans for regions=" +
regions.size());
- }
-
if (plan.isEmpty()) {
- return;
+ throw new HBaseIOException("unable to compute plans for regions=" +
regions.size());
Review comment:
Oh, just saw the 'plan == null' in the old code. This is a bit strange
as the plan is a function parameter, but anyway, not your fault.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
