ndimiduk commented on a change in pull request #2501:
URL: https://github.com/apache/hbase/pull/2501#discussion_r503517527
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFailedAppendAndSync.java
##########
@@ -256,6 +273,27 @@ public void testLockupAroundBadAssignSync() throws
IOException {
Threads.sleep(1);
}
}
+
+ try {
+ dodgyWAL.throwAppendException = false;
+ dodgyWAL.throwSyncException = false;
+ dodgyWAL.throwArchiveException = true;
+ Pair<Path, Long> pair = new Pair<Path, Long>();
+ pair.setFirst(new Path("/a/b/"));
+ pair.setSecond(100L);
+ dodgyWAL.archive(pair);
+ } catch (Throwable ioe) {
+ }
+ while (true) {
+ try {
+ // one more abort needs to be called
+ Mockito.verify(services,
Mockito.atLeast(2)).abort(Mockito.anyString(),
+ (Throwable) Mockito.anyObject());
+ break;
+ } catch (WantedButNotInvoked t) {
+ Threads.sleep(1);
Review comment:
This will be a flaky test. Please use the `waitFor` pattern already
provided on the testing utility class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
