busbey commented on a change in pull request #2539:
URL: https://github.com/apache/hbase/pull/2539#discussion_r504073569
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java
##########
@@ -1339,6 +1339,19 @@
/** Configuration key for the algorithm used for creating jks key, a string
*/
public static final String CRYPTO_KEY_ALGORITHM_CONF_KEY =
"hbase.crypto.key.algorithm";
+ /**
+ * Configuration key for the hash algorithm used for generating key hash in
encrypted HFiles.
+ * This is a MessageDigest algorithm identifier string, like "MD5",
"SHA-256" or "SHA-384".
+ * (default: "MD5" for backward compatibility reasons)
+ */
+ public static final String CRYPTO_KEY_HASH_ALGORITHM_CONF_KEY =
"hbase.crypto.key.hash.algorithm";
Review comment:
Please put these somewhere other than HConstants per this note:
> // NOTICE!!!! Please do not add a constants here, unless they are
referenced by a lot of classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
