saintstack commented on a change in pull request #2537:
URL: https://github.com/apache/hbase/pull/2537#discussion_r504391227
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java
##########
@@ -150,6 +151,12 @@ public static void sanityCheck(final Configuration c,
final TableDescriptor td)
warnOrThrowExceptionForFailure(logWarn, message, null);
}
+ // Meta table shouldn't be set as read only, otherwise it will impact
region assignments
+ if (td.isReadOnly() && TableName.isMetaTableName(td.getTableName())) {
+ String message = "Meta table can't be set as read only.";
+ warnOrThrowExceptionForFailure(false, message, null);
Review comment:
Super nit/NOT IMPORTANT/NEXT TIME: just pass in the message rather than
save to local variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
