[
https://issues.apache.org/jira/browse/HBASE-5925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270258#comment-13270258
]
stack commented on HBASE-5925:
------------------------------
I sort of follow. I don't understand the bit where you say "But here we read
the old config item only!'. Help me out Anoop.
HBASE-3272 is what changed this config. Looking at the patch over there, will
it help explaining why code is the way it is? (Maybe it doesn't!)
> Issue with only using the old config param hbase.hstore.compactionThreshold
> but not the corresponding new one
> -------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5925
> URL: https://issues.apache.org/jira/browse/HBASE-5925
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Priority: Minor
>
> One observation while going through the code:-
> In MemStoreFlusher constructor
> {code}
> this.blockingStoreFilesNumber =
> conf.getInt("hbase.hstore.blockingStoreFiles", 7);
> if (this.blockingStoreFilesNumber == -1) {
> this.blockingStoreFilesNumber = 1 +
> conf.getInt("hbase.hstore.compactionThreshold", 3);
> }
> {code}
> Here as per the code if hbase.hstore.blockingStoreFiles is configured as -1,
> we are making this value to be 1+ min files to compact
> But here we read the old config item only!
> Here also we need to read the new config 1st and if not there then the old
> one.. Is this a miss?
> Like
> conf.getInt("hbase.hstore.compaction.min",
> conf.getInt("hbase.hstore.compactionThreshold", 3))
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
