[
https://issues.apache.org/jira/browse/HBASE-24609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214033#comment-17214033
]
Michael Stack commented on HBASE-24609:
---------------------------------------
bq. I define the format in name as a noun, not a verb, so I think it is OK? It
means the format of the catalog family.
Not how I read it but could work.
{quote}And it only contains formatting and parsing so I think it is fine to
share it across the code base. The problem for MTA is that it accept a
Connection and can do read write of meta table. For CCFF, you need to get the
result by your own, so in general, as you said, finally it will be in only the
places where we can actually access meta.{quote}
MTA tried to hide this stuff. Keep it internal. Now you spread the format/parse
about the code base. If tendency is toward hiding this stuff again inside CMTA
and MTA (or RSS) then ok -- should doc this tendency in code comments (and the
intent to dissolve MTA and make CMTA read-only, etc.) so others can help your
notion along. In PR its suggested you make the 'format' class package private
at least.
The line from HConstants is from 2009, from a different time. Since then a
bunch of work has been done to formalize 'ColumnFamily' as the term we use
referring to column families/HStores. I'm trying to point out that your use of
'Family' goes against this precedent reviving the antique.
> Move MetaTableAccessor out of hbase-client
> ------------------------------------------
>
> Key: HBASE-24609
> URL: https://issues.apache.org/jira/browse/HBASE-24609
> Project: HBase
> Issue Type: Task
> Components: amv2, Client, meta
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Priority: Major
> Fix For: 3.0.0-alpha-1
>
>
> On master branch we have AsyncMetaTableAccessor which is used at client side
> and MetaTableAccessor has lots of internal methods for implementing
> assignment, which is not part of our client code.
> So let's move it to hbase-server, and in the future, maybe in hbase-balancer?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
