[
https://issues.apache.org/jira/browse/HBASE-25183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214955#comment-17214955
]
Michael Stack edited comment on HBASE-25183 at 10/15/20, 8:56 PM:
------------------------------------------------------------------
(Ignoring comments on lack of 'respect' and accusations of 'aggression' or that
I didn't do background reading...)
{quote}Is the motiviation here just shrinking hbase-server module or is there
some other driver?
{quote}
Answering my own question after reading above (correct me if I'm wrong
[~zhangduo]), it seems the refactor of balancer is mainly because we want to
shrink the hbase-server module size. This seems to be the motivation (My
current opinion on the balancer refactor I offer above. I won't repeat).
So, while my work in HBASE-25185, 'is not my[Duos'] plan' regards this issue,
it does help w/ the larger objective of shrinking hbase-server module size by
introducing a new module into which we can start moving classes from
hbase-server, and it addresses another Duo plan for dissolving
MetaTableAccessor (We take a slight step backward on HBASE-23933 because of the
limbo state of favored nodes feature but I'd think it fine given the benefits
introduced).
Presuming the above (shout if I have it wrong [~zhangduo]), I can move off this
issue now that I have gotten what I needed coming here.
-May I have a +1- [~zhangduo] -on HBASE-25185 please?- <= Oh, ignore. I just
saw you had questions on this PR. Let me address. Thanks.
Thanks
was (Author: stack):
(Ignoring comments on lack of 'respect' and accusations of 'aggression' or that
I didn't do background reading...)
bq. Is the motiviation here just shrinking hbase-server module or is there some
other driver?
Answering my own question after reading above (correct me if I'm wrong
[~zhangduo]), it seems the refactor of balancer is mainly because we want to
shrink the hbase-server module size. This seems to be the motivation (My
current opinion on the balancer refactor I offer above. I won't repeat).
So, while my work in HBASE-25185, 'is not my[Duos'] plan' regards this issue,
it does help w/ the larger objective of shrinking hbase-server module size by
introducing a new module into which we can start moving classes from
hbase-server, and it addresses another Duo plan for dissolving
MetaTableAccessor (We take a slight step backward on HBASE-23933 because of the
limbo state of favored nodes feature but I'd think it fine given the benefits
introduced).
Presuming the above (shout if I have it wrong [~zhangduo]), I can move off this
issue now that I have gotten what I needed coming here.
May I have a +1 [~zhangduo] on HBASE-25185 please?
Thanks
> Move more balancer related classes to hbase-balancer
> ----------------------------------------------------
>
> Key: HBASE-25183
> URL: https://issues.apache.org/jira/browse/HBASE-25183
> Project: HBase
> Issue Type: Umbrella
> Components: Balancer
> Reporter: Duo Zhang
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
