Reidddddd commented on a change in pull request #2312: URL: https://github.com/apache/hbase/pull/2312#discussion_r506057237
########## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java ########## @@ -1401,6 +1401,22 @@ */ public static final int BATCH_ROWS_THRESHOLD_DEFAULT = 5000; + public static final int DEFAULT_SLOW_LOG_RING_BUFFER_SIZE = 256; Review comment: why do we still introduce these parameters in HConstants. I thought we have avoided to add parameters in it for quite a long time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org