wchevreuil commented on a change in pull request #2546:
URL: https://github.com/apache/hbase/pull/2546#discussion_r507641174
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
##########
@@ -712,8 +707,14 @@ public void terminate(String reason, Exception cause,
boolean clearMetrics,
worker.entryReader.interrupt();
}
}
+ //If worker is already stopped but there was still entries batched,
+ //we need to clear buffer used for non processed entries
+ worker.clearWALEntryBatch();
}
+ if (this.replicationEndpoint != null) {
+ this.replicationEndpoint.stop();
Review comment:
Nope, you are right. This ended up here while resolving the conflicts.
Let me move it prior to the block stopping the workers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
