busbey commented on a change in pull request #2419:
URL: https://github.com/apache/hbase/pull/2419#discussion_r508709843
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/fs/HFileSystem.java
##########
@@ -82,7 +82,10 @@ public HFileSystem(Configuration conf, boolean
useHBaseChecksum)
// Create the default filesystem with checksum verification switched on.
// By default, any operation to this FilterFileSystem occurs on
// the underlying filesystem that has checksums switched on.
- this.fs = FileSystem.get(conf);
+ // This FS#get(URI, conf) clearly indicates in the javadoc that if the FS
is
+ // not created it will initialize the FS and return that created FS. If it
is
+ // already created it will just return the FS that was already created.
Review comment:
To Duo's request, add in something like:
```
// We take pains to funnel all of our FileSystem instantiation through this
call to ensure
// we never need to call FS.initialize ourself so that we do not have to
track any state to
// avoid calling initialize more than once.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
