apurtell commented on a change in pull request #2574:
URL: https://github.com/apache/hbase/pull/2574#discussion_r512083604
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
##########
@@ -7364,4 +7366,157 @@ protected HStoreForTesting(final HRegion region,
return super.doCompaction(cr, filesToCompact, user, compactionStartTime,
newFiles);
}
}
+
+ @Test
+ public void testCloseNoInterrupt() throws Exception {
+ byte[] cf1 = Bytes.toBytes("CF1");
+ byte[][] families = { cf1 };
+
+ Configuration conf = new Configuration(CONF);
+ // Disable close thread interrupt and server abort behavior
+ conf.setBoolean(HRegion.CLOSE_WAIT_ABORT, false);
+ region = initHRegion(tableName, method, conf, families);
+
+ final CountDownLatch latch = new CountDownLatch(1);
+ final AtomicBoolean holderInterrupted = new AtomicBoolean();
+ Thread holder = new Thread(new Runnable() {
+ @Override
+ public void run() {
+ try {
+ LOG.info("Starting region operation holder");
+ region.startRegionOperation(Operation.SCAN);
+ latch.countDown();
+ try {
+ Thread.sleep(10*1000);
+ } catch (InterruptedException e) {
+ LOG.info("Interrupted");
+ holderInterrupted.set(true);
Review comment:
If you throw an assertion inside a Thread runnable it won't unwind to
the JUnit test method that forked the thread, it will be caught by
Thread.UncaughtExceptionHandler, which is not what I think we want. So I set
the boolean and then test it in the unit test method where an assertion will
propagate the way I want. Maybe JUnit installs its own UEH, didn't test, but
the way I have done it makes more sense to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
