bharathv commented on pull request #2574: URL: https://github.com/apache/hbase/pull/2574#issuecomment-716907446
> The original motivation for interrupting RPCs in flight was to address the case where we get stuck closing the region, so we can be less aggressive and wait until we actually seem to be stuck That makes sense to me. In most cases (which are short lived operations), the lock holder should gracefully release the lock in the time window and no point force-interrupting them. My concern on the loop was readability of code flow and I see your point of repeated interrupts incase the interrupt is swallowed and reset by the layers underneath. Another way to address both these issues is to have a boolean state in the HRegion (abortOperations or some such) that is set only after the graceful time window has passed. Instead of polling isInterrupted(), the threads now check for this boolean flag. Not a big deal I guess but just wanted to point out incase you haven't already considered this approach. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
