petersomogyi commented on a change in pull request #2590:
URL: https://github.com/apache/hbase/pull/2590#discussion_r513578511
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/HBCKServerCrashProcedure.java
##########
@@ -169,4 +170,16 @@ public boolean visit(Result result) throws IOException {
return this.reassigns;
}
}
+
+ /**
+ * The RegionStateNode will not have a location if a confirm of an OPEN
fails. On fail,
+ * the RegionStateNode regionLocation is set to null. This is 'looser' than
the test done
+ * in the superclass. The HBCKSCP has been scheduled by an operator via
hbck2 probably at the
+ * behest of a report of an 'Unknown Server' in the 'HBCK Report'. Let the
operators operation
+ * succeed even in case where the region location in the RegionStateNode is
null.
+ */
+ @Override
+ protected boolean isMatchingRegionLocation(RegionStateNode rsn) {
Review comment:
Yes, this is my understanding. Thanks for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
