huaxiangsun commented on a change in pull request #2584: URL: https://github.com/apache/hbase/pull/2584#discussion_r513784019
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncNonMetaRegionLocator.java ########## @@ -196,8 +200,33 @@ private boolean tryComplete(LocateRequest req, CompletableFuture<RegionLocations MAX_CONCURRENT_LOCATE_REQUEST_PER_TABLE, DEFAULT_MAX_CONCURRENT_LOCATE_REQUEST_PER_TABLE); this.locatePrefetchLimit = conn.getConfiguration().getInt(LOCATE_PREFETCH_LIMIT, DEFAULT_LOCATE_PREFETCH_LIMIT); - this.useMetaReplicas = - conn.getConfiguration().getBoolean(USE_META_REPLICAS, DEFAULT_USE_META_REPLICAS); + + // Get the region locator's meta replica mode. + this.metaReplicaMode = CatalogReplicaMode.valueOf(conn.getConfiguration() + .get(LOCATOR_META_REPLICAS_MODE, CatalogReplicaMode.None.toString())); + + switch (this.metaReplicaMode) { + case LoadBalance: + String replicaSelectorClass = conn.getConfiguration(). + get(RegionLocator.LOCATOR_META_REPLICAS_MODE_LOADBALANCE_SELECTOR, + CatalogReplicaLoadBalanceReplicaSimpleSelector.class.getName()); + + this.metaReplicaSelector = CatalogReplicaLoadBalanceReplicaSelectorFactory.createSelector( + replicaSelectorClass, META_TABLE_NAME, conn); + break; + case None: + // If user does not configure LOCATOR_META_REPLICAS_MODE, let's check the legacy config. + if (this.metaReplicaMode == CatalogReplicaMode.None) { + boolean userMetaReplicas = conn.getConfiguration().getBoolean(USE_META_REPLICAS, + DEFAULT_USE_META_REPLICAS); + if (userMetaReplicas) { + this.metaReplicaMode = CatalogReplicaMode.HedgedRead; Review comment: The default actually is None, so will keep it as it is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org