apurtell commented on a change in pull request #2574:
URL: https://github.com/apache/hbase/pull/2574#discussion_r514400489
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -8777,23 +8936,36 @@ public void closeRegionOperation(Operation operation)
throws IOException {
if (operation == Operation.SNAPSHOT) {
stores.values().forEach(HStore::postSnapshotOperation);
}
+ regionLockHolders.remove(Thread.currentThread());
lock.readLock().unlock();
if (coprocessorHost != null) {
coprocessorHost.postCloseRegionOperation(operation);
}
}
+ /**
+ * If a handler thread is eligible for interrupt, make it ineligible. Should
be paired
+ * with {{@link #enableInterrupts()}.
+ */
+ protected void disableInterrupts() {
+ regionLockHolders.computeIfPresent(Thread.currentThread(), (t,b) -> false);
+ }
+
+ /**
+ * If a handler thread was made ineligible for interrupt via {{@link
#disableInterrupts()},
+ * make it eligible again. No-op if interrupts are already enabled.
+ */
+ protected void enableInterrupts() {
+ regionLockHolders.computeIfPresent(Thread.currentThread(), (t,b) -> true);
+ }
+
/**
* This method needs to be called before any public call that reads or
* modifies stores in bulk. It has to be called just before a try.
* #closeBulkRegionOperation needs to be called in the try's finally block
* Acquires a writelock and checks if the region is closing or closed.
- * @throws NotServingRegionException when the region is closing or closed
Review comment:
I can put them back but I believe this was done in response to feedback
from another reviewer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
